Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22253 )
Change subject: KUDU-613: Make segment metrics more relevant ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22253/3/src/kudu/util/slru_cache.h File src/kudu/util/slru_cache.h: http://gerrit.cloudera.org:8080/#/c/22253/3/src/kudu/util/slru_cache.h@67 PS3, Line 67: std::atomic<bool> in_protected_segment; > However, I think there is simpler way to handling this: you just need to > store the pointer to metrics in Whoops -- please ignore this fragment: it was a part of a draft on musing how to getting rid of 'in_protected_segment' and related logic at all. In any case, that's outside of the scope of this patch, I guess. -- To view, visit http://gerrit.cloudera.org:8080/22253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id44828be41a19593e6808debf7e9ba8e1fc4dcca Gerrit-Change-Number: 22253 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 23:50:19 +0000 Gerrit-HasComments: Yes
