Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )
Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances ...................................................................... Patch Set 3: > > 60 seconds might be a long time if it goes to that point, do we > > want to use the below macro for this test? > > SKIP_IF_SLOW_NOT_ALLOWED() > > This test scenario usually completes in about 1 second if running > non-TSAN bits on a machine with contemporary hardware, and with > TSAN bits it's under 3 seconds. The outlier runs happen rarely, > and a lot of depends on how busy the test node is. > > If treating ASSERT_EVENTUALLY the way you suggested, several other > tests should be marked with SKIP_IF_SLOW_NOT_ALLOWED(), and I think > the best way doing so in a separate changelist. > > What do you think? Ah, it seems the proper fix is different. I'll post a new PS soon. -- To view, visit http://gerrit.cloudera.org:8080/22427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e Gerrit-Change-Number: 22427 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 21:07:54 +0000 Gerrit-HasComments: No
