Hello Mahesh Reddy, Ashwani Raina, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22427
to look at the new patch set (#4).
Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................
[util] improve MaintenanceManagerTest.TestRunningInstances
This patch introduces a ScopedCleanup instance to unregister maintenance
operations registered by MaintenanceManagerTest.TestRunningInstances if
ASSERT_EVENTUALLY triggers. Also, the timeout for AssertEventually is
increased two-fold to reduce flakiness when running on busy nodes. The
motivation for this patch was seeing the test scenario failing [1] with
the following TSAN warning due to CHECK() in
MaintenanceOp::~MaintenanceOp():
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call)
[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1738131961.3963207
Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 44 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/22427/4
--
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
