Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22427 )
Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances ...................................................................... [util] improve MaintenanceManagerTest.TestRunningInstances This patch introduces a ScopedCleanup instance to unregister maintenance operations registered by MaintenanceManagerTest.RunningInstances if ASSERT_EVENTUALLY triggers. Also, the scenario is now more resilient to scheduler anomalies. The motivation for this patch was a report on test failures [1] with the following TSAN warning due to CHECK() in MaintenanceOp::~MaintenanceOp(): WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) [1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1738131961.3963207 Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e Reviewed-on: http://gerrit.cloudera.org:8080/22427 Reviewed-by: Abhishek Chennaka <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/util/maintenance_manager-test.cc 1 file changed, 44 insertions(+), 15 deletions(-) Approvals: Abhishek Chennaka: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/22427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e Gerrit-Change-Number: 22427 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]>
