Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing ...................................................................... Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-backup/build.gradle File java/kudu-backup/build.gradle: http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-backup/build.gradle@38 PS18, Line 38: api libs.yetusAnnotations BTW, in kudu-spark-tools and kudu-spark this is still listed as implementation type dependency. What makes kudu-backup special in that regard? Consider adding a comment here to explain. kudu-spark/build.gradle: implementation libs.yetusAnnotations kudu-spark-tools/build.gradle: implementation libs.yetusAnnotations http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-hive/build.gradle File java/kudu-hive/build.gradle: http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-hive/build.gradle@27 PS18, Line 27: api libs.hadoopCommon Just to double-check: do we indeed need to declare this transitive dependency as 'api' here? Consider adding a comment to explain why 'api', not 'implementation' is the correct type of dependency here. BTW, with the recent fixes on publishing and shading in PS18, do we even need to manually add this transitive dependency manually? Could Gradle7 decide what's needed or not on itself here or we still need to add this? -- To view, visit http://gerrit.cloudera.org:8080/22768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0 Gerrit-Change-Number: 22768 Gerrit-PatchSet: 18 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 16 May 2025 03:57:02 +0000 Gerrit-HasComments: Yes
