Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek
Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#19).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the implementation and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the compileUnshaded configuration to be extending the
compileOnly configuration. This was necessary to correct the scope of
these dependencies. This change also made it necessary to add the
compileUnshaded dependencies explicitly to the test compile path as
well[0].
[0] https://blog.gradle.org/introducing-compile-only-dependencies
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
M java/kudu-test-utils/build.gradle
13 files changed, 202 insertions(+), 170 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/19
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 19
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
