Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22945 )
Change subject: [socket] No need for static check of SO_REUSEPORT macro ...................................................................... Patch Set 1: Code-Review+1 (2 comments) LGTM, just a few nits for the commit description http://gerrit.cloudera.org:8080/#/c/22945/1//COMMIT_MSG Commit Message: PS1: formatting nit: could you reformat the description to follow the guidelines outlined at https://kudu.apache.org/docs/contributing.html as 'generic git commit guidelines and good practices', at particular https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines Thank you! http://gerrit.cloudera.org:8080/#/c/22945/1//COMMIT_MSG@10 PS1, Line 10: linux nit: Linux -- To view, visit http://gerrit.cloudera.org:8080/22945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I477d47251a45a57e4179d8affd2273cb25768383 Gerrit-Change-Number: 22945 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 May 2025 16:27:34 +0000 Gerrit-HasComments: Yes
