Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22945 )

Change subject: [socket] No need for static check of SO_REUSEPORT macro
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22945/1//COMMIT_MSG
Commit Message:

PS1:
> formatting nit: could you reformat the description to follow the guidelines
Done.
I wonder if we can hook commit message rules to git that does all these checks.
There is one link that does describes steps to achieve something similar: 
https://dev.to/mbarzeev/a-git-hook-for-commit-messages-validation-no-husky-just-js-1hni
It would be worth trying though, could make life easier.


http://gerrit.cloudera.org:8080/#/c/22945/1//COMMIT_MSG@10
PS1, Line 10:
> nit: Linux
Done



--
To view, visit http://gerrit.cloudera.org:8080/22945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I477d47251a45a57e4179d8affd2273cb25768383
Gerrit-Change-Number: 22945
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 28 May 2025 04:57:13 +0000
Gerrit-HasComments: Yes

Reply via email to