Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22945 )
Change subject: [socket] No need for static check of SO_REUSEPORT macro ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/22945/1//COMMIT_MSG Commit Message: PS1: > Done. Right: as of now, people can introduce any helpful automation as git hooks in their workspaces. In my case, I configured my editor to take care of that (i.e. break lines where needed) when I'm writing commit messages. As for gerrit itself, one can see the ruler (dotted vertical line) on the right, so it's easy to spot those nits when reviewing patches. Probably, there is some level of automation to automate vetting of patches in gerrit based on that formatting criteria, but I haven't explored that. However, it shouldn't be a hard rule to reject a commit with lines over 72 characters in description. Sometimes it's necessary to include a stack trace or a snippet from logs into the description as-is or with minimal changes. It might be beneficial to add instructions of installing formatting hook helpers into the Kudu upstream docs, similar to the instructions of installing the Gerrit commit-msg hook. However, it's not a must-have (compared with Gerrit commit-msg hook) but rather a recommendation. Feel free to explore this and continue discussion at #kudu-general Slack channel and corresponding mailing lists, if necessary. -- To view, visit http://gerrit.cloudera.org:8080/22945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I477d47251a45a57e4179d8affd2273cb25768383 Gerrit-Change-Number: 22945 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 May 2025 19:24:37 +0000 Gerrit-HasComments: Yes
