Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23064 )
Change subject: [tablet] eliminate ABI warning by replacing std::pair with struct in ComputeLowerAndUpperBound ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG@7 PS1, Line 7: [tablet] eliminate ABI warning by replacing std::pair with struct in ComputeLowerAndUpperBound Reformat this per commit message guidelines here https://kudu.apache.org/docs/contributing.html#_submitting_patches http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG@9 PS1, Line 9: Wpsabi Can you also add the warning message? http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG@10 PS1, Line 10: when C++17 : is enabled. The compiler note indicates that the calling convention for such : types was changed in GCC 10.0 and reverted in GCC 10.1 to match C++14 behavior. Maybe add source links for reference, if any. http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG@15 PS1, Line 15: double, double> Is this warning applicable to just the 'double' type? There are more instances in the code where a pair is returned, e.g. pair<int64_t, int64_t> DoQueries in cache-bench? -- To view, visit http://gerrit.cloudera.org:8080/23064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4db585a8eaf152f1fa2884e72e38a4e7c5efa1 Gerrit-Change-Number: 23064 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 23 Jun 2025 11:39:19 +0000 Gerrit-HasComments: Yes
