KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23064 )
Change subject: [tablet] fix -Wpsabi warning in ComputeLowerAndUpperBound on Rocky ARM ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG@7 PS1, Line 7: [tablet] fix -Wpsabi warning in ComputeLowerAndUpperBound on Rocky ARM > Reformat this per commit message guidelines here https://kudu.apache.org/do Done http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG@9 PS1, Line 9: when c > Can you also add the warning message? Done http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG@10 PS1, Line 10: : kudu/src/kudu/tablet/compaction_policy.cc:304:63: note: parameter passing for argument : of type ‘std::pair<double, double>’ when C++17 is enabled changed to match C+ > Maybe add source links for reference, if any. Done http://gerrit.cloudera.org:8080/#/c/23064/1//COMMIT_MSG@15 PS1, Line 15: > Is this warning applicable to just the 'double' type? There are more instan Yes, this is the only occurrence of this type of warning found. Although DoQueries() also returns a std::pair, it does not trigger the same -Wpsabi warning because it uses std::pair<int64_t, int64_t>, which involves only integer types. In contrast, ComputeLowerAndUpperBound() returns std::pair<double, double>, and the presence of floating-point types introduces ABI-specific handling—particularly on AArch64 platforms using hard-float ABIs. -- To view, visit http://gerrit.cloudera.org:8080/23064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4db585a8eaf152f1fa2884e72e38a4e7c5efa1 Gerrit-Change-Number: 23064 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Jun 2025 02:52:00 +0000 Gerrit-HasComments: Yes
