Hello Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23064
to look at the new patch set (#2).
Change subject: [tablet] fix -Wpsabi warning in ComputeLowerAndUpperBound on
Rocky ARM
......................................................................
[tablet] fix -Wpsabi warning in ComputeLowerAndUpperBound on Rocky ARM
GCC 10.1 on Rocky Linux ARM emits the following warning when compiling with
C++17:
kudu/src/kudu/tablet/compaction_policy.cc:304:63: note: parameter passing for
argument
of type ‘std::pair<double, double>’ when C++17 is enabled changed to match
C++14 in GCC 10.1
304 | std::pair<double, double> ComputeLowerAndUpperBound() const {
| ^
This is due to a change in ABI handling of std::pair in C++17 mode,
introduced in GCC 10.0 and reverted in 10.1 for compatibility.
To eliminate the warning and ensure ABI stability across platforms,
this patch replaces std::pair<double, double> with a custom BoundRange struct
as the return type of ComputeLowerAndUpperBound().
Build environment:
- gcc version: 11.5.0 20240719 (Red Hat 11.5.0-5) (GCC)
- ld (GNU gold) version: 1.16
No functional behavior is changed.
References:
- https://gcc.gnu.org/gcc-10/changes.html
Change-Id: Iab4db585a8eaf152f1fa2884e72e38a4e7c5efa1
---
M src/kudu/tablet/compaction_policy.cc
1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/23064/2
--
To view, visit http://gerrit.cloudera.org:8080/23064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab4db585a8eaf152f1fa2884e72e38a4e7c5efa1
Gerrit-Change-Number: 23064
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
