Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23016 )
Change subject: [server] KUDU-1457 [2/n] Add support for IPv6 ...................................................................... Patch Set 5: Code-Review+1 (5 comments) Overall LGTM, just a few nits and questions. http://gerrit.cloudera.org:8080/#/c/23016/5/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: PS5: Do you think we need to add at least a few basic/smoke tests into webserver-test.cc that are IPv6-specific? Overall, what's your take on adding IPv6-specific part into the Kudu test scaffolding -- do you anticipate to have a separate patch for that, etc.? http://gerrit.cloudera.org:8080/#/c/23016/5/src/kudu/server/webserver.cc@499 PS5, Line 499: * style nit for here and elsewhere: the asterisk sticks to the type, not the variable http://gerrit.cloudera.org:8080/#/c/23016/5/src/kudu/server/webserver.cc@500 PS5, Line 500: push_back(Sockaddr(*s_in)) nit: might this be just addrs->emplace_back(*s_in) or even addrs->emplace_back(*reinterpret_cast<struct sockaddr_in*>(sockaddrs[i]);) ? http://gerrit.cloudera.org:8080/#/c/23016/5/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch File thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch: PS5: Do plan you to add this new code into the Cloudera's squeasel repo at some point, removing this patch? Or this patch is actually sourced from there instead? http://gerrit.cloudera.org:8080/#/c/23016/5/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@46 PS5, Line 46: *) Is this a bug in the current version without the patch? -- To view, visit http://gerrit.cloudera.org:8080/23016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee175a00a7ac9e20a31ddb8396468cfcd8f3b6f9 Gerrit-Change-Number: 23016 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 18 Jul 2025 02:50:00 +0000 Gerrit-HasComments: Yes
