Hello Marton Greber, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23016
to look at the new patch set (#7).
Change subject: KUDU-1457 [2/n] add IPv6 support to squeasel function
......................................................................
KUDU-1457 [2/n] add IPv6 support to squeasel function
As part of adding IPv6 support, this patch enables squeasel to
return a generic address structure for bound addresses instead of IPv4
address structure in all cases. Caller can typecast returned address
structure to either IPv4 (i.e. sockaddr_in) or IPv6 (i.e. sockaddr_in6)
depending on the address family.
The patch fixes the following issues:
1. Check the config for null before converting to integer using atoi
to avoid crash due to SIGSEGV. This is possible when using a fake
context that doesn’t bear valid config for request timeout.
2. Fix test_parse_port_string test to correct the expectation that
wrongly considers 0 as invalid port. 0 has special meaning i.e.
'any port'.
3. Add 4 new test cases for different scenarios applicable to
se_get_bound_addresses changes.
4. Add runtime library for successful compilation of unit_test.
Without these libraries, unit_test binary creation fails due to
undefined reference errors during linking.
5. Add negative test scenarios for IPv6 to test_parse_port_string.
6. Remove wrong test case from test_should_keep_alive. The test case
incorrectly expects HTTP/1.1 Connection keep-alive request to fail
'keep-alive' check. The expectation to fail the check applies to
previous case i.e. HTTP/1.1 with 'Connection close' request.
7. Remove setting of conn.status_code as it serves no purpose.
Change-Id: Iee175a00a7ac9e20a31ddb8396468cfcd8f3b6f9
---
M src/kudu/server/webserver.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch
3 files changed, 351 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/23016/7
--
To view, visit http://gerrit.cloudera.org:8080/23016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee175a00a7ac9e20a31ddb8396468cfcd8f3b6f9
Gerrit-Change-Number: 23016
Gerrit-PatchSet: 7
Gerrit-Owner: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
