Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23016 )
Change subject: KUDU-1457 [2/n] add IPv6 support to squeasel function ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23016/5/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch File thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch: http://gerrit.cloudera.org:8080/#/c/23016/5/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@46 PS5, Line 46: *) > Considering out parameter type(struct sockaddr_in ***addrs), it seems sq_ge I think Alexey meant we’re using sizeof(struct sockaddr_in *) (pointer size) instead of sizeof(struct sockaddr_in) (struct size). -- To view, visit http://gerrit.cloudera.org:8080/23016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee175a00a7ac9e20a31ddb8396468cfcd8f3b6f9 Gerrit-Change-Number: 23016 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 28 Jul 2025 12:33:26 +0000 Gerrit-HasComments: Yes
