Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23205 )
Change subject: [Java] KUDU-3677: Fix optional dependencies ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/23205/1/java/gradle/publishing.gradle File java/gradle/publishing.gradle: http://gerrit.cloudera.org:8080/#/c/23205/1/java/gradle/publishing.gradle@101 PS1, Line 101: > nit: stray space symbols Done http://gerrit.cloudera.org:8080/#/c/23205/1/java/gradle/publishing.gradle@102 PS1, Line 102: def filteredImplDeps = implDeps - shadowDeps - unshadedDeps : def finalDeps = filteredImplDeps + unshadedDeps > Wouldn't it be the same if having just We use implDeps - shadowDeps - unshadedDeps to remove all auto-managed entries, and then manually add back unshadedDeps in a controlled way in the generated POM — ensuring the correct scope, no optional=true, and preserving exclusions. In short, this is needed to deal with duplicate listings in different configurations. How do duplicates exist: shadow inherits all dependencies from compileUnshaded compileOnly inherits all dependencies from compileUnshaded http://gerrit.cloudera.org:8080/#/c/23205/1/java/gradle/publishing.gradle@103 PS1, Line 103: > nit: remove the trailing space Done http://gerrit.cloudera.org:8080/#/c/23205/1/java/gradle/publishing.gradle@127 PS1, Line 127: if (!dep.excludeRules.isEmpty()) { : def exclusionsNode = depNode.appendNode("exclusions") : dep.excludeRules.each { ex -> : def exclusion = exclusionsNode.appendNode("exclusion") : exclusion.appendNode("groupId", ex.group ?: "*") : exclusion.appendNode("artifactId", ex.module ?: "*") > Did you verify that we don't have anything else but exclusions that could r Yes, I manually verified the generated POMs with this fix. -- To view, visit http://gerrit.cloudera.org:8080/23205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b7593f595b64082d86fb64cbe8f38ff9b2ccb88 Gerrit-Change-Number: 23205 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 22 Jul 2025 18:57:31 +0000 Gerrit-HasComments: Yes
