Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/23205 )
Change subject: [Java] KUDU-3677: Fix optional dependencies
......................................................................
Patch Set 3:
> For example consider the below sets of dependencies:
> implDeps = {A,B,C,D}
> shadowDeps = {D,E,F}
> unshadedDeps = {C,D,G}
>
> The following entries would be
>
> def filteredImplDeps = implDeps - shadowDeps - unshadedDeps
> def finalDeps = filteredImplDeps + unshadedDeps
> = {A,B,C,D,G}
> def finalDeps = implDeps - shadowDep
> = {A,B,C}
>
> Although this would not be the case in our situation as
> unshadedDeps are a subset of shadowDeps as we have the below
> configuration:
>
> configurations.shadow.extendsFrom(configurations.compileUnshaded)
>
> But having the above logic helps in any future corner cases and
> better understanding.
Thanks a lot for the example!
Could you please add that as a comment to the corresponding lines in the file?
It would be nice to have the explanation for the posterity readers and
maintainers of this file.
--
To view, visit http://gerrit.cloudera.org:8080/23205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b7593f595b64082d86fb64cbe8f38ff9b2ccb88
Gerrit-Change-Number: 23205
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Sun, 27 Jul 2025 00:56:23 +0000
Gerrit-HasComments: No
