Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23205 )
Change subject: [Java] KUDU-3677: Fix optional dependencies ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23205/1/java/gradle/publishing.gradle File java/gradle/publishing.gradle: http://gerrit.cloudera.org:8080/#/c/23205/1/java/gradle/publishing.gradle@102 PS1, Line 102: def filteredImplDeps = implDeps - shadowDeps - unshadedDeps : def finalDeps = filteredImplDeps + unshadedDeps > We use implDeps - shadowDeps - unshadedDeps to remove all auto-managed entr Thank you for the explanation. I just looked at this from simple arithmetic perspective, and from that perspective the result seems to be the same, regardless of duplicate listings unless there is something funny with dealing with elements of the dependency sets. In other words, the 'filteredImplDeps' is just a temporary set, and it's not used anywhere else below, IIUC. def filteredImplDeps = implDeps - shadowDeps - unshadedDeps def finalDeps = filteredImplDeps + unshadedDeps If there isn't anything funny in operations with elements of the dependency sets, computing the 'finalDeps' by removing the temporary results in: def finalDeps = implDeps - shadowDeps Am I missing something? -- To view, visit http://gerrit.cloudera.org:8080/23205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b7593f595b64082d86fb64cbe8f38ff9b2ccb88 Gerrit-Change-Number: 23205 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 23 Jul 2025 15:33:20 +0000 Gerrit-HasComments: Yes
