Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing ...................................................................... Patch Set 3: Code-Review+1 (1 comment) LGTM! Just one question: If default parameter values are set on config, do you think similar test verification is required for default parameter case? Feel free to ignore if default parameter values are not applicable to Replication config. http://gerrit.cloudera.org:8080/#/c/23121/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23121/3//COMMIT_MSG@13 PS3, Line 13: auto-generates nit: Is there any heuristics involved in coming up with default config? -- To view, visit http://gerrit.cloudera.org:8080/23121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9 Gerrit-Change-Number: 23121 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 28 Jul 2025 13:31:46 +0000 Gerrit-HasComments: Yes
