Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing ...................................................................... Patch Set 3: > (5 comments) > > Thanks for taking a look! > > ParameterTool is already covered by tests in Flink: > https://github.com/a0x8o/flink/tree/941b7259fe26a82908204f1b8d66d436357c8a66/flink-java/src/test/java/org/apache/flink/api/java/utils > > The rest of the open questions can be answered by examining the > classes that ParameterTool relies on; I’ve added those findings to > your comments. I decided not to add basic tests to our repository > because they would introduce unnecessary bloat. That sounds good to me. Thank you for the answers! -- To view, visit http://gerrit.cloudera.org:8080/23121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9 Gerrit-Change-Number: 23121 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 30 Jul 2025 16:26:30 +0000 Gerrit-HasComments: No
