Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing ...................................................................... Patch Set 3: (1 comment) In the current test setup we use the defaults: the reader and writer configs only pass through the master addresses. If your question is about verifying that setting a specific config parameter works, TestReplicationConfigParser.java covers that at the unit-test level. Beyond that, the Flink connectors simply receive the configs and it’s their responsibility to apply them. Both the Flink source and sink connectors are well tested. Let me know if that answers your question. http://gerrit.cloudera.org:8080/#/c/23121/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23121/3//COMMIT_MSG@13 PS3, Line 13: auto-generates > nit: Is there any heuristics involved in coming up with default config? In our test setup the default reader and writer configs just plumb the source/sink Kudu master addresses. It's just a test setup thingy. -- To view, visit http://gerrit.cloudera.org:8080/23121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9 Gerrit-Change-Number: 23121 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 28 Jul 2025 14:40:30 +0000 Gerrit-HasComments: Yes
