Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23016 )
Change subject: KUDU-1457 [2/n] add IPv6 support to squeasel function ...................................................................... Patch Set 7: Verified+1 (1 comment) unrelated test failures of known flaky tests in DEBUG build: * ErrorType/TabletServerDiskErrorTest.TestRandomOpSequence/2 * TserverAddedDuringRebalancingTest.TserverStarts (KUDU-3635) * DeleteTabletITest.TestLeaderElectionDuringDeleteTablet (KUDU-2335) * SecurityITest.TestEncryptionWithKMSIntegrationMultipleServers http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch File thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch: http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@10 PS6, Line 10: macO > Even without these changes (i.e. on a clean squeasel branch), the build fai Thank you for adding the comments and updating build rules for other targets -- it might be useful for people doing future updates in squeasel itself. Right: I'm aware the Makefile for squeasel doesn't allow it to build those targets on macOS, at least for the contemporary macOS version. The point was to reflect on that since this patch touches that Makefile. You've added the comments and now it looks good to me -- thank you for addressing that. Yes -- surprisingly, -ldl also valid on macOS, but dl library isn't present (or needed) on macOS. It seems the CLANG/LLVM linker is aware of that flag, and process it accordingly anyway. -- To view, visit http://gerrit.cloudera.org:8080/23016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee175a00a7ac9e20a31ddb8396468cfcd8f3b6f9 Gerrit-Change-Number: 23016 Gerrit-PatchSet: 7 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 01 Aug 2025 03:31:25 +0000 Gerrit-HasComments: Yes
