Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23510 )
Change subject: KUDU-3478 Add Java client examples test script ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23510/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/23510/1/build-support/jenkins/build-and-test.sh@606 PS1, Line 606: # Run the Java examples tests : if ! ./test-java-examples.sh ; then : TESTS_FAILED=1 : FAILURES="$FAILURES"$'Java examples tests failed\n' : fi > Wouldn't it be enough to run this along with Java tests locally (as already Here in the $ENABLE_DIST_TEST branch is where we end up in pre-commit tests. Yes we could put the example testing after this branch, so it is tested no matter what $ENABLE_DIST_TEST is. However that also means that if we do coverage runs we also run the example tests. (I wanted to avoid this) As far as I see this block we need to put the java example testing in these two blocks to satisfy the following: - in dist test setup run the examples locally - in non dist test, non coverage local runs we should run the example tests - in coverage builds we should avoid running the examples. If you see that the covarge skipping is not important I can just put only one instance of example testing at the end of the whole $ENABLE_DIST_TEST at line before the set +x. http://gerrit.cloudera.org:8080/#/c/23510/1/examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java File examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java: http://gerrit.cloudera.org:8080/#/c/23510/1/examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java@148 PS1, Line 148: Insert insert = table.newInsert(); > I guess this might result in sporadic test failures: the values for all the Nice catch actually, thanks! Done. -- To view, visit http://gerrit.cloudera.org:8080/23510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f45295d4dfa32e28f9a6369612bb5bc25a2a038 Gerrit-Change-Number: 23510 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 15:11:17 +0000 Gerrit-HasComments: Yes
