Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23510 )
Change subject: KUDU-3478 Add Java client examples test script ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/23510/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/23510/1/build-support/jenkins/build-and-test.sh@606 PS1, Line 606: # Run the Java examples tests : if ! ./test-java-examples.sh ; then : TESTS_FAILED=1 : FAILURES="$FAILURES"$'Java examples tests failed\n' : fi > Here in the $ENABLE_DIST_TEST branch is where we end up in pre-commit tests OK, it looks good enough to me as-is. I was just looking from the standpoint of this extra test ideally becoming a part of gradle's local test run, similar to what we have with ctest for client_examples-test.sh in the C++ part of the project, and that was the original of my comment. -- To view, visit http://gerrit.cloudera.org:8080/23510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f45295d4dfa32e28f9a6369612bb5bc25a2a038 Gerrit-Change-Number: 23510 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 10 Oct 2025 18:57:21 +0000 Gerrit-HasComments: Yes
