Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23510 )
Change subject: KUDU-3478 Add Java client examples test script ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23510/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/23510/1/build-support/jenkins/build-and-test.sh@606 PS1, Line 606: # Run the Java examples tests : if ! ./test-java-examples.sh ; then : TESTS_FAILED=1 : FAILURES="$FAILURES"$'Java examples tests failed\n' : fi Wouldn't it be enough to run this along with Java tests locally (as already done below, lines 633-637)? I see that in this scope we only run tests via dist-test, and rely on submitting all them quite fast because we aren't waiting here for their completion once submitted. http://gerrit.cloudera.org:8080/#/c/23510/1/examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java File examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java: http://gerrit.cloudera.org:8080/#/c/23510/1/examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java@148 PS1, Line 148: Insert insert = table.newInsert(); I guess this might result in sporadic test failures: the values for all the columns (including key columns) are generated randomly, and the random generator is seeded differently with every invocation since it uses the default Random's constructor. It might be OK for an example Java Kudu client application like this, but once it's run as a part of the pre-commit CI pipeline, this needs to be more reliable. For that, maybe replace newInsert() with newUpsert() here? -- To view, visit http://gerrit.cloudera.org:8080/23510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f45295d4dfa32e28f9a6369612bb5bc25a2a038 Gerrit-Change-Number: 23510 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 04:59:09 +0000 Gerrit-HasComments: Yes
