Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23482 )
Change subject: KUDU-1261 [Java] Add write support for Array Type ...................................................................... Patch Set 15: (2 comments) one small nit and a question for followup patches, otherwise looks good to me http://gerrit.cloudera.org:8080/#/c/23482/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java: http://gerrit.cloudera.org:8080/#/c/23482/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@43 PS12, Line 43: public final class ArrayCellView > OK, this sounds good to me. I saw that this is indeed modified to package private in followup patches, however the PartialRow class has two 'public ArrayCellView getArray()' methods, that exposes this class publicly. Since those methods are only used in PartialRow internally, they would be better declared as private in my opinion. What do you guys think? Maybe I'm missing something from an API design perspective. http://gerrit.cloudera.org:8080/#/c/23482/15/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/23482/15/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@2073 PS15, Line 2073: (byte[][] this cast is redundant, as the check at 2071 ensures the instance type -- To view, visit http://gerrit.cloudera.org:8080/23482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe5e243eafe12a8977d40204dacab99624451eb Gerrit-Change-Number: 23482 Gerrit-PatchSet: 15 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 08:50:48 +0000 Gerrit-HasComments: Yes
