Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23482 )
Change subject: KUDU-1261 [Java] Add write support for Array Type ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/23482/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java: http://gerrit.cloudera.org:8080/#/c/23482/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@43 PS12, Line 43: public final class ArrayCellView > I saw that this is indeed modified to package private in followup patches, +1 http://gerrit.cloudera.org:8080/#/c/23482/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/23482/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@992 PS16, Line 992: // Case 3: validity == null → infer validity from non-nulls : boolean[] inferred = new boolean[values.length]; : for (int i = 0; i < values.length; i++) { : inferred[i] = (values[i] != null); : } : return inferred; I don't quite understand why the logic here is different from in the 'if (validity != null && validity.length == 0) {...}' clause above. Why not to have the same behavior in both cases? -- To view, visit http://gerrit.cloudera.org:8080/23482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe5e243eafe12a8977d40204dacab99624451eb Gerrit-Change-Number: 23482 Gerrit-PatchSet: 16 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 23:11:56 +0000 Gerrit-HasComments: Yes
