Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23571 )

Change subject: KUDU-1261 use bits not bytes for validity in array1d.fbs
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23571/4/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java:

PS4:
consider using camelcase (lower for variables)


http://gerrit.cloudera.org:8080/#/c/23571/4/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@74
PS4, Line 74: validity_elem_num
rename to something like validityBytes


http://gerrit.cloudera.org:8080/#/c/23571/4/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@80
PS4, Line 80: data_elem_num
rename to something like numDataElements



--
To view, visit http://gerrit.cloudera.org:8080/23571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09d281f7e76f6ead3fac8cb853eea503b8fb0bfe
Gerrit-Change-Number: 23571
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Thu, 23 Oct 2025 22:26:07 +0000
Gerrit-HasComments: Yes

Reply via email to