Hello Xuebin Su, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23571
to look at the new patch set (#5).
Change subject: KUDU-1261 use bits not bytes for validity in array1d.fbs
......................................................................
KUDU-1261 use bits not bytes for validity in array1d.fbs
This changelist switches to using one-validity-bit-per-array-element
approach in encoding one-dimensional arrays. It takes care both of
the C++ and the Java side, so now they both speak the same language
w.r.t. the array element validity.
I added a few new sub-scenarios to cover some of the edge cases with
the new approach, but the existing tests also provide good enough
coverage for this update.
Change-Id: I09d281f7e76f6ead3fac8cb853eea503b8fb0bfe
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M src/kudu/common/array_cell_view.h
M src/kudu/common/array_type_serdes-test.cc
M src/kudu/common/array_type_serdes.h
M src/kudu/common/serdes/array1d.fbs
M src/kudu/util/bitmap-test.cc
M src/kudu/util/bitmap.cc
M src/kudu/util/bitmap.h
11 files changed, 217 insertions(+), 146 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/23571/5
--
To view, visit http://gerrit.cloudera.org:8080/23571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09d281f7e76f6ead3fac8cb853eea503b8fb0bfe
Gerrit-Change-Number: 23571
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Xuebin Su <[email protected]>
