Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23571 )
Change subject: KUDU-1261 use bits not bytes for validity in array1d.fbs ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23571/4/java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java File java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java: http://gerrit.cloudera.org:8080/#/c/23571/4/java/kudu-client/src/main/java/org/apache/kudu/client/Array1dSerdes.java@110 PS4, Line 110: validity_bytes[idx >> 3] &= ~(1 << (idx & 7)); : } Do we need this given this a new array with all 0s anyway? -- To view, visit http://gerrit.cloudera.org:8080/23571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09d281f7e76f6ead3fac8cb853eea503b8fb0bfe Gerrit-Change-Number: 23571 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 23 Oct 2025 22:42:24 +0000 Gerrit-HasComments: Yes
