Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23611 )
Change subject: [test] Skip test if hostname has no DNS record ...................................................................... Patch Set 1: > Are other tests potentially affected? > For example quickly searching for GetFQDN is also used in > rpc-test-base in CreateMessenger. Which is used in the parametrized > test suite TestRpc where CreateMessenger is used. That would depend on number of factors (assuming ipv4 resolution is working): 1. Whether host name resolution is done with AF_INET6 hint (i.e. ip_config_mode is set to "ipv6"). 2. Whether test has mandatory requirement for canonical fqdn. 3. Whether test is is being called for "ipv6" ip_config_name param. Since rpc-test seems to be passing on node with missing IPv6 name record for the host, I am guessing those tests are not affected. Nevertheless, I will check and confirm. On a side note, not all unit tests run with 'ipv6' ip_config_mode (for example some tests in net_util-test.cc suite) for the obvious reason that only applicable tests are impacted based on newly added and modified code coverage requirement at the time. However, I have some WIP patches that are including more and more tests to work with 'ipv6' and 'dual' modes as well. -- To view, visit http://gerrit.cloudera.org:8080/23611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id377c73a752e18324dbd83aad7e613b3ba99ee6b Gerrit-Change-Number: 23611 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 30 Oct 2025 16:51:33 +0000 Gerrit-HasComments: No
