Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23611 )
Change subject: [test] Skip test if hostname has no DNS record ...................................................................... Patch Set 1: Code-Review+1 (2 comments) > Are other tests potentially affected? > For example quickly searching for GetFQDN is also used in > rpc-test-base in CreateMessenger. Which is used in the parametrized > test suite TestRpc where CreateMessenger is used. +1 Probably, this check along with verifying whether IPv6 stack is configured at the test node might be performed in a more centralized manner and used in other scenarios similar to how SKIP_IF_SLOW_NOT_ALLOWED() macro is used now. http://gerrit.cloudera.org:8080/#/c/23611/1/src/kudu/master/mini_master-test.cc File src/kudu/master/mini_master-test.cc: http://gerrit.cloudera.org:8080/#/c/23611/1/src/kudu/master/mini_master-test.cc@68 PS1, Line 68: std::string nit: maybe, introduce `using std::string;` and remove the 'std::' prefix here and at line 45 as well? http://gerrit.cloudera.org:8080/#/c/23611/1/src/kudu/master/mini_master-test.cc@77 PS1, Line 77: if (!GetFQDN(&hostname).ok()) { : GTEST_SKIP() << "Skipping test, hostname has no DNS record for " << GetParam() << " mode."; : } Is this possible to do this in the very beginning of the scenario, or maybe even in SetUp() method? -- To view, visit http://gerrit.cloudera.org:8080/23611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id377c73a752e18324dbd83aad7e613b3ba99ee6b Gerrit-Change-Number: 23611 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 30 Oct 2025 23:16:45 +0000 Gerrit-HasComments: Yes
