Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23611 )
Change subject: [test] Skip test if hostname has no DNS record ...................................................................... Patch Set 1: (2 comments) > (2 comments) > > > Are other tests potentially affected? > > For example quickly searching for GetFQDN is also used in > > rpc-test-base in CreateMessenger. Which is used in the > parametrized > > test suite TestRpc where CreateMessenger is used. > > +1 > > Probably, this check along with verifying whether IPv6 stack is > configured at the test node might be performed in a more > centralized manner and used in other scenarios similar to how > SKIP_IF_SLOW_NOT_ALLOWED() macro is used now. That would certainly be a good and clean approach that requires its own patch as it would be a comprehensive one and touch a good number of tests. On rpc-test-base question, I checked and confirmed that rpc-test-base falls in #3 category. We do have parametrised test suite TestRpc but it uses parameter to determine the family of wildcard address that is used as server rpc bind address. If param is TCP_IPv4_SSL, socket is bound to '0.0.0.0', or '::' if param is TCP_IPv6_SSL, etc. These tests don't work with 'ip_config_mode' as an input param so it remains 'ipv4' for messenger host. In a nutshell, there is no affect as of now. However, if we do decide to have tests run with different messenger host family types, we would require similar condition. I don't anticipate such requirement arising for that, at present. http://gerrit.cloudera.org:8080/#/c/23611/1/src/kudu/master/mini_master-test.cc File src/kudu/master/mini_master-test.cc: http://gerrit.cloudera.org:8080/#/c/23611/1/src/kudu/master/mini_master-test.cc@68 PS1, Line 68: std::string > nit: maybe, introduce `using std::string;` and remove the 'std::' prefix he Done http://gerrit.cloudera.org:8080/#/c/23611/1/src/kudu/master/mini_master-test.cc@77 PS1, Line 77: if (!GetFQDN(&hostname).ok()) { : GTEST_SKIP() << "Skipping test, hostname has no DNS record for " << GetParam() << " mode."; : } > Is this possible to do this in the very beginning of the scenario, or maybe Yes, it should be doable as long as ip_config_mode flag is set beforehand. Maybe it is possible to move this to SetUp() method. I am not sure though. It would require some further exploration in order to figure out whether the calling test is using canonical fqdn. If it does, then there needs to be a way to propagate that error back (if test is to be skipped in main function). Or maybe skip from SetUp() itself if that is possible. -- To view, visit http://gerrit.cloudera.org:8080/23611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id377c73a752e18324dbd83aad7e613b3ba99ee6b Gerrit-Change-Number: 23611 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 31 Oct 2025 09:36:58 +0000 Gerrit-HasComments: Yes
