Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23630 )
Change subject: [tests] Add IPv6 coverage to multiple tests ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23630/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23630/2//COMMIT_MSG@16 PS2, Line 16: For client-test, the coverage is not added for 'dual' mode because of : the additional time it takes to run those tests. How much additional time does it take? ie would it be linear in terms of just one other ip_config? Maybe add SKIP_IF_SLOW_NOT_ALLOWED in ClientParamTest's SetUp if GetParam is dual? What do you think about this? http://gerrit.cloudera.org:8080/#/c/23630/2/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/23630/2/src/kudu/util/net/net_util.cc@537 PS2, Line 537: *out = Substitute("[$0]", kWildcardIpV6Addr); In dual mode, why bind to wildcard [::] instead of loopback [::1]? http://gerrit.cloudera.org:8080/#/c/23630/2/src/kudu/util/net/net_util.cc@850 PS2, Line 850: string GetBindIpForDaemon(int index, BindMode bind_mode) { Should GetBindIpForDaemon() return with brackets for consistency? (ToIpInterface adds brackets) -- To view, visit http://gerrit.cloudera.org:8080/23630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc0df890c71e101964e7c7c84b5847963fab1451 Gerrit-Change-Number: 23630 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 14:12:01 +0000 Gerrit-HasComments: Yes
