Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23630 )
Change subject: [tests] Add IPv6 coverage to multiple tests ...................................................................... Patch Set 2: > Curios if you got a chance to run the updated tests with and > without the changes to see the time difference? > > Compilation failure reported in the build: > /home/jenkins-slave/workspace/build_and_test/src/kudu/rpc/rpc-test-base.h:39:10: > fatal error: kudu/rpc/rtest.pb.h: No such file or directory > #include "kudu/rpc/rtest.pb.h" Yes, but on my local machine. On dist-test cluster the timing varies by a lot. Without this change, client-test took 807 seconds With this change, client-test took 1307 seconds. Thanks for the heads up on compilation error. I moved SKIP_IF_HOSTNAME_RESOLUTION_FAILURE_EXPECTED() definition to src/kudu/util/test_util.h. That is where SKIP_IF_SLOW_NOT_ALLOWED() is defined as well. That fixed the error. -- To view, visit http://gerrit.cloudera.org:8080/23630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc0df890c71e101964e7c7c84b5847963fab1451 Gerrit-Change-Number: 23630 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 13 Nov 2025 09:34:55 +0000 Gerrit-HasComments: No
