Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23630 )
Change subject: [tests] Add IPv6 coverage to multiple tests ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23630/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23630/2//COMMIT_MSG@16 PS2, Line 16: For client-test, the coverage is not added for 'dual' mode because of : the additional time it takes to run those tests. > How much additional time does it take? ie would it be linear in terms of ju IIRC, it was around 250 seconds for dual mode on my laptop. However, this could reduce way down on dist-test slaves (as per dist-test test logs). The increase in time taken is more or less linear with addition of each mode. Yeah, skipping tests for dual mode conditionally (based on whether slow tests are allowed or not) sounds good to me. http://gerrit.cloudera.org:8080/#/c/23630/2/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/23630/2/src/kudu/util/net/net_util.cc@537 PS2, Line 537: *out = Substitute("[$0]", kWildcardIpV6Addr); > In dual mode, why bind to wildcard [::] instead of loopback [::1]? Binding to loopback for dual mode won't accept IPv4 requests. The idea is to allow both IPv4 and IPv6 connections to succeed when the server is configured with 'dual' mode i.e. dual stack. http://gerrit.cloudera.org:8080/#/c/23630/2/src/kudu/util/net/net_util.cc@850 PS2, Line 850: string GetBindIpForDaemon(int index, BindMode bind_mode) { > Should GetBindIpForDaemon() return with brackets for consistency? (ToIpInte Not required as the return type is a string and is passed to network functions like getaddrinfo for DNS resolution and such functions expect node names that can be resolved and Ip enclosed in brackets would fail with unknown name or service. The calls that require bracket enclosed IP go through either some transformative objects like HostPort that keep track of both host and port and both of them are likely to get used in those functions. Or explicit transformation invoked via ToIpInterface. -- To view, visit http://gerrit.cloudera.org:8080/23630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc0df890c71e101964e7c7c84b5847963fab1451 Gerrit-Change-Number: 23630 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 12 Nov 2025 11:11:54 +0000 Gerrit-HasComments: Yes
