Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23681 )
Change subject: KUDU-3716 Add version to IPKI CA CSR ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23681/2/src/kudu/security/ca/cert_management.cc File src/kudu/security/ca/cert_management.cc: http://gerrit.cloudera.org:8080/#/c/23681/2/src/kudu/security/ca/cert_management.cc@87 PS2, Line 87: 0x30000000L nit: since the version for the CSR is now set for OpenSSL versions starting 3.0.0, but the verification of the version now is present only starting 3.4.0, does it make sense to ad a small unit test to make sure sure the version is set as expected by using X509_REQ_get_version() API call? cert-management-test.cc might be a good place to add one, I guess. -- To view, visit http://gerrit.cloudera.org:8080/23681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I735a56d444009a867fbcab9b78d0053cea593b95 Gerrit-Change-Number: 23681 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 17 Nov 2025 20:34:22 +0000 Gerrit-HasComments: Yes
