Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/23681 )
Change subject: KUDU-3716 Add version to IPKI CA CSR ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23681/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23681/2//COMMIT_MSG@9 PS2, Line 9: OpenSSL 3.4.0 added a version check to certificate signing > It seems they added it a bit earlier, at least in the git source repo it's Thanks, fixed. http://gerrit.cloudera.org:8080/#/c/23681/2//COMMIT_MSG@10 PS2, Line 10: signing > nit: remove Actually, this sounds confusing, but it is needed here: it causes signing previously working CSRs to fail. Maybe it should be rephrased somehow? http://gerrit.cloudera.org:8080/#/c/23681/2/src/kudu/security/ca/cert_management.cc File src/kudu/security/ca/cert_management.cc: http://gerrit.cloudera.org:8080/#/c/23681/2/src/kudu/security/ca/cert_management.cc@87 PS2, Line 87: 0x30000000L > nit: since the version for the CSR is now set for OpenSSL versions starting Added an extra assertion to an existing test case, not sure it's worth adding a whole new test, but I can refactor it into its separate test case if you think it would be cleaner that way. -- To view, visit http://gerrit.cloudera.org:8080/23681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I735a56d444009a867fbcab9b78d0053cea593b95 Gerrit-Change-Number: 23681 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 18 Nov 2025 22:09:19 +0000 Gerrit-HasComments: Yes
