Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23681 )
Change subject: KUDU-3716 Add version to IPKI CA CSR ...................................................................... Patch Set 3: Code-Review+1 (2 comments) LGTM, but IWYU isn't happy yet. Please update the code to address the missing header issue. Thank you! http://gerrit.cloudera.org:8080/#/c/23681/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23681/2//COMMIT_MSG@10 PS2, Line 10: signing > Actually, this sounds confusing, but it is needed here: it causes signing p That looked OK to me, but maybe rephrase the last part with the below to avoid having to many 'signing' in one sentence: ... previously working CSRs to fail with the below error ... http://gerrit.cloudera.org:8080/#/c/23681/2/src/kudu/security/ca/cert_management.cc File src/kudu/security/ca/cert_management.cc: http://gerrit.cloudera.org:8080/#/c/23681/2/src/kudu/security/ca/cert_management.cc@87 PS2, Line 87: 0x30000000L > Added an extra assertion to an existing test case, not sure it's worth addi That's good enough, thanks! -- To view, visit http://gerrit.cloudera.org:8080/23681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I735a56d444009a867fbcab9b78d0053cea593b95 Gerrit-Change-Number: 23681 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 18 Nov 2025 22:38:11 +0000 Gerrit-HasComments: Yes
