Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23892 )
Change subject: [cmake_modules] fix linker detection ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/23892/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23892/1//COMMIT_MSG@16 PS1, Line 16: because it uses: : -fuse-ld={kudu}/thirdparty/clang-toolchain/bin I'm not sure that's what it uses. At least per cmake module's code, it provides the full path the the binary, not just the directory where lld can be found: -fuse-ld=${THIRDPARTY_TOOLCHAIN_DIR}/bin/ld.lld http://gerrit.cloudera.org:8080/#/c/23892/1//COMMIT_MSG@19 PS1, Line 19: -fuse-ld=lld -B{kudu}/thirdparty/clang-toolchain/bin Would it work if using the absolute path to the binary, something like -fuse-ld=${THIRDPARTY_TOOLCHAIN_DIR}/bin/lld ? In other words, what is the benefit to separate the path to the linker binary and the binary name? http://gerrit.cloudera.org:8080/#/c/23892/1/cmake_modules/KuduLinker.cmake File cmake_modules/KuduLinker.cmake: http://gerrit.cloudera.org:8080/#/c/23892/1/cmake_modules/KuduLinker.cmake@27 PS1, Line 27: thirdparty lld nit: I'm not a big fan of using space-separated identifiers in cmake -- sometimes it brings surprises; I'd rather change this to "3rd-party-lld" or similar http://gerrit.cloudera.org:8080/#/c/23892/1/cmake_modules/KuduLinker.cmake@35 PS1, Line 35: -fuse-ld=lld : -B${THIRDPARTY_TOOLCHAIN_DIR}/bin Why is this better than -fuse-ld=${THIRDPARTY_TOOLCHAIN_DIR}/bin/lld ? -- To view, visit http://gerrit.cloudera.org:8080/23892 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I567caf9b73b75020facce8ce800e50662af60f39 Gerrit-Change-Number: 23892 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 18:50:39 +0000 Gerrit-HasComments: Yes
