Zoltan Martonka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23892 )

Change subject: [cmake_modules] fix linker detection
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23892/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23892/1//COMMIT_MSG@16
PS1, Line 16: because it uses:
            :   -fuse-ld={kudu}/thirdparty/clang-toolchain/bin
> I'm not sure that's what it uses.  At least per cmake module's code, it pro
Please run this on any normal linux system:
clang++ main.cpp  -fuse-ld=/usr/bin/ld.bfd -o test <- OK
g++ main.cpp  -fuse-ld=/usr/bin/ld.bfd -o test <- FAIL
g++: error: unrecognized command-line option ‘-fuse-ld=/usr/bin/ld.bfd’


http://gerrit.cloudera.org:8080/#/c/23892/1//COMMIT_MSG@19
PS1, Line 19: -fuse-ld=lld -B{kudu}/thirdparty/clang-toolchain/bin
> Would it work if using the absolute path to the binary, something like
g++ does not accept a path (at least between 7.5 and 15.2). only clang does .



--
To view, visit http://gerrit.cloudera.org:8080/23892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I567caf9b73b75020facce8ce800e50662af60f39
Gerrit-Change-Number: 23892
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Fri, 06 Feb 2026 13:59:43 +0000
Gerrit-HasComments: Yes

Reply via email to