Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23892
to look at the new patch set (#2).
Change subject: [cmake_modules] fix linker detection
......................................................................
[cmake_modules] fix linker detection
KuduLinker.cmake does not work as intended.
The code is meant to prioritize:
1. lld
2. lld built in thirdparty
3. gold
However, the check for the thirdparty linker always fails,
because it uses:
-fuse-ld={kudu}/thirdparty/clang-toolchain/bin
but it should use:
-fuse-ld=lld -B{kudu}/thirdparty/clang-toolchain/bin
g++ does not accepts a path in -fuse-ld, only clang (and
fake mac g++) does.
The GNU gold linker is officially deprecated.
This change will be needed for upgrading to
LLVM 16 with ORC codegen, since gold crashes
with an internal linker error on RHEL 9.
Change-Id: I567caf9b73b75020facce8ce800e50662af60f39
---
M cmake_modules/KuduLinker.cmake
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/23892/2
--
To view, visit http://gerrit.cloudera.org:8080/23892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I567caf9b73b75020facce8ce800e50662af60f39
Gerrit-Change-Number: 23892
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
