Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23904 )
Change subject: KUDU-3700 Add swagger verification script docs ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23904/2//COMMIT_MSG Commit Message: PS2: > It would be great to call this script as a part of regular building/testing Yeah, that’s a good idea. I’ll handle it in a follow-up CL since it touches build/test wiring and needs a bit more discussion about where to hook it. http://gerrit.cloudera.org:8080/#/c/23904/2/build-support/verify_swagger_spec.py File build-support/verify_swagger_spec.py: http://gerrit.cloudera.org:8080/#/c/23904/2/build-support/verify_swagger_spec.py@183 PS2, Line 183: if not source_methods: > what does this actually check? what is the type of the source_methods varia The source_methods can be None (handler definition not found), set() (handler found but no direct req.request_method checks detected), or {"GET", "POST", ...} (methods inferred). This line triggers the empty-set case. So the type is effectively Optional[Set[str]]. http://gerrit.cloudera.org:8080/#/c/23904/2/build-support/verify_swagger_spec.py@211 PS2, Line 211: parse_args > would it be possible to add a "--help" option to print these flags and the argparse already adds -h/--help and will print all flags + defaults. Example: ./build-support/verify_swagger_spec.py --help. If you want, I can add an explicit Options section in the header comment. -- To view, visit http://gerrit.cloudera.org:8080/23904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ca60becef11eb2170544f87fafc5d9aa4110a31 Gerrit-Change-Number: 23904 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 19 Feb 2026 15:47:23 +0000 Gerrit-HasComments: Yes
