Gabriella Lotz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24285
Change subject: [auto_rebalancer] close TODO in CheckMoveCompleted ...................................................................... [auto_rebalancer] close TODO in CheckMoveCompleted Investigated replacing the GetConsensusState RPC in CheckMoveCompleted() with a read from the master's in-memory catalog (as suggested by the existing TODO). The in-memory approach is not viable: the catalog is updated asynchronously via tablet reports, so immediately after BulkChangeConfig succeeds the destination peer is absent from the in-memory config. This is indistinguishable from the peer having been genuinely evicted, so the error conditions fire spuriously on every check, causing moves to be incorrectly cancelled and replace markers to be needlessly cleared. Remove the TODO and replace it with an explanatory comment. The RPC remains the correct data source for this function. This changelist contains no functional modifications. Change-Id: Iba021539fbfaca5905fbbf4abbb6e2a61db1f7dc --- M src/kudu/master/auto_rebalancer.cc 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/24285/1 -- To view, visit http://gerrit.cloudera.org:8080/24285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iba021539fbfaca5905fbbf4abbb6e2a61db1f7dc Gerrit-Change-Number: 24285 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]>
