Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24285 )
Change subject: [auto_rebalancer] close TODO in CheckMoveCompleted ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24285/1/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24285/1/src/kudu/master/auto_rebalancer.cc@874 PS1, Line 874: // Immediately after BulkChangeConfig succeeds, the destination peer is absent : // from the in-memory committed config, indistinguishable from it having been : // genuinely evicted. The GetConsensusState RPC provides a causally consistent : // snapshot from the leader and is the correct data source for these decisions. I'm not sure I understand. BulkChangeConfig requests are sent to tablet servers that host leader replica for a tablet, and those tablet servers maintain the in-memory committed config, etc. It cannot be in the memory of CatalogManager, right? AFAIK, CatalogManager receives updates from tablet servers on the membership of tablet replicas through tserver-to-master heartbeating, and updates its internal data based on the info it collects from tablet servers. IIUC, the idea behind this comment was to avoid issuing GetConsensusState RPC directly, but rely on the information eventually reported via tserver-to-master heartbeats. -- To view, visit http://gerrit.cloudera.org:8080/24285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba021539fbfaca5905fbbf4abbb6e2a61db1f7dc Gerrit-Change-Number: 24285 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 08 May 2026 14:34:18 +0000 Gerrit-HasComments: Yes
