Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24285
to look at the new patch set (#2).
Change subject: [auto_rebalancer] close TODO in CheckMoveCompleted
......................................................................
[auto_rebalancer] close TODO in CheckMoveCompleted
Investigated replacing the GetConsensusState RPC in
CheckMoveCompleted() with a read from CatalogManager, as suggested
by the existing TODO. The approach is not viable: CatalogManager's
consensus state is populated via tserver-to-master heartbeats and
may lag the tserver's actual Raft state by up to one heartbeat
interval. Immediately after BulkChangeConfig succeeds, the
destination peer may not yet appear in CatalogManager --
indistinguishable from it having been genuinely evicted by Raft.
The error conditions in CheckMoveCompleted() would fire spuriously,
causing moves to be incorrectly cancelled and replace markers to be
needlessly cleared.
Remove the TODO and replace it with an explanatory comment.
This changelist contains no functional modifications.
Change-Id: Iba021539fbfaca5905fbbf4abbb6e2a61db1f7dc
---
M src/kudu/master/auto_rebalancer.cc
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/24285/2
--
To view, visit http://gerrit.cloudera.org:8080/24285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba021539fbfaca5905fbbf4abbb6e2a61db1f7dc
Gerrit-Change-Number: 24285
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
