Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24326 )
Change subject: [fs] speed up LBM startup by replaying small metadata files from memory ...................................................................... Patch Set 3: Code-Review+1 (3 comments) LGTM overall, a few nits. Maybe, Ashwani has more feedback on PS3. http://gerrit.cloudera.org:8080/#/c/24326/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24326/3//COMMIT_MSG@69 PS3, Line 69: latency nit: duration? http://gerrit.cloudera.org:8080/#/c/24326/3//COMMIT_MSG@79 PS3, Line 79: latency nit: duration? http://gerrit.cloudera.org:8080/#/c/24326/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/24326/3/src/kudu/fs/log_block_manager.cc@1572 PS3, Line 1572: unique_ptr<RandomAccessFile> reader = : MaybePreloadMetadataIntoMemory(metadata_path, raw_reader.get()); : if (reader) { : raw_reader.reset(); : } else { : reader = std::move(raw_reader); nit: alternatively, MaybePreloadMetadataIntoMemory() might take ownership of 'raw_reader' passed as std::unique_ptr and return either a new instance of the memory-based reader or the original reader it took as the second parameter. If needed, callers could distinguish between success/failure comparing the raw pointer of the returned instance with a saved 'raw_reader.get()' pointer. -- To view, visit http://gerrit.cloudera.org:8080/24326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacbe12977ae945e7fa2f97a41aef250b03495cd4 Gerrit-Change-Number: 24326 Gerrit-PatchSet: 3 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 26 May 2026 17:18:49 +0000 Gerrit-HasComments: Yes
