Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24326 )
Change subject: [fs] speed up LBM startup by replaying small metadata files from memory ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Looks good to me! Just a couple of nits. http://gerrit.cloudera.org:8080/#/c/24326/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/24326/2/src/kudu/fs/log_block_manager.cc@1445 PS2, Line 1445: OError > Good catch. The encryption_header_size_ machinery is left-over scaffolding Thanks for the explanation. If this is something you would like to address in future, it would be great if you can create a ticket for that work and link it in this gerrit or maybe even mention in the comments here, for posterity. http://gerrit.cloudera.org:8080/#/c/24326/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/24326/4/src/kudu/fs/log_block_manager.cc@170 PS4, Line 170: (excluding any encryption header) This could be confusing. It is better to explicitly state that current version doesn't support encrypted metadata. -- To view, visit http://gerrit.cloudera.org:8080/24326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacbe12977ae945e7fa2f97a41aef250b03495cd4 Gerrit-Change-Number: 24326 Gerrit-PatchSet: 4 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 27 May 2026 06:16:23 +0000 Gerrit-HasComments: Yes
