Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24326 )
Change subject: [fs] speed up LBM startup by replaying small metadata files from memory ...................................................................... Patch Set 4: (3 comments) Thanks a lot fot the review. http://gerrit.cloudera.org:8080/#/c/24326/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24326/3//COMMIT_MSG@69 PS3, Line 69: syscall > nit: duration? Done http://gerrit.cloudera.org:8080/#/c/24326/3//COMMIT_MSG@79 PS3, Line 79: syscall > nit: duration? Done http://gerrit.cloudera.org:8080/#/c/24326/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/24326/3/src/kudu/fs/log_block_manager.cc@1572 PS3, Line 1572: uint64_t data_file_size = 0; : Status read_status; : while (true) { : BlockRecordPB record; : read_status = pb_reader.ReadNextPB(&record); : if (!read_status.ok()) { > nit: alternatively, MaybePreloadMetadataIntoMemory() might take ownership o Thans a lot, done. -- To view, visit http://gerrit.cloudera.org:8080/24326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacbe12977ae945e7fa2f97a41aef250b03495cd4 Gerrit-Change-Number: 24326 Gerrit-PatchSet: 4 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 27 May 2026 03:54:17 +0000 Gerrit-HasComments: Yes
