Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24285 )
Change subject: KUDU-3732 Get consensus state from CatalogManager in auto-rebalancer ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24285/3/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24285/3/src/kudu/master/auto_rebalancer.cc@557 PS3, Line 557: RETURN_NOT_OK(leader_hp.ResolveAddresses(&resolved)); : ConsensusServiceProxy proxy(messenger_, resolved[0], leader_hp.host()); : RETURN_NOT_OK(proxy.BulkChangeConfig(req, &resp, &rpc)); : if (resp.has_error()) return StatusFromPB(r > With the introduction of this new logic, there is now a possibility of a TO Thank you for pointing this out. I've added req.set_cas_config_opid_index(pre_opid_index) to the BulkChangeConfigRequestPB in ExecuteMoves. If another actor modifies the config between when we read pre_opid_index and when the request reaches the leader, Raft rejects it with a CAS error, the move is treated as a scheduling failure and dropped this round, and the rebalancer retries next cycle with a fresh index. http://gerrit.cloudera.org:8080/#/c/24285/3/src/kudu/master/auto_rebalancer.cc@921 PS3, Line 921: > Could it happen that 'config_opid_idx' field is absent in the 'replica_move Done, I have added a DCHECK() before. -- To view, visit http://gerrit.cloudera.org:8080/24285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba021539fbfaca5905fbbf4abbb6e2a61db1f7dc Gerrit-Change-Number: 24285 Gerrit-PatchSet: 4 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 27 May 2026 14:39:01 +0000 Gerrit-HasComments: Yes
